permit setting probe.kubernetes.interval to 0
#3012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...which is useful if we want to disable periodic fetching of all objects. Previously the interval was also used to set the initial backoff of the reconnect logic. A zero value there would result in _no_ backoff. So instead we now just use the default, which is 10s which also happens to be the default probe.kubernetes.interval, so there is no change in behaviour for the stock settings.
rade
force-pushed
the
permit-zero-resync
branch
from
6d16994 to
5dad27c
Compare
bboreham
approved these changes
Jan 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...which is useful if we want to disable periodic fetching of all objects.
Previously the interval was also used to set the initial backoff of the reconnect logic (all this code was introduced in #2562). A zero value there would result in no backoff. So instead we now just use the default, which is 10s which also happens to be the default
probe.kubernetes.interval, so there is no change in behaviour for the stock settings.